commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (IO-235) Bugs in CopyUtilsTest test cases?
Date Wed, 04 Aug 2010 23:04:17 GMT

     [ https://issues.apache.org/jira/browse/IO-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Niall Pemberton resolved IO-235.
--------------------------------

         Assignee: Niall Pemberton
    Fix Version/s: 2.0
       Resolution: Fixed

Fixed: http://svn.apache.org/viewvc?view=revision&revision=982430

> Bugs in CopyUtilsTest test cases?
> ---------------------------------
>
>                 Key: IO-235
>                 URL: https://issues.apache.org/jira/browse/IO-235
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Niall Pemberton
>             Fix For: 2.0
>
>
> testCopy_byteArrayToWriter() has the following code:
> {code}
> ByteArrayOutputStream baout = new ByteArrayOutputStream();
> OutputStream out = new YellOnFlushAndCloseOutputStream(baout, false, true); // out is
not used
> Writer writer = new java.io.OutputStreamWriter(baout, "US-ASCII"); // uses baout - should
it use out instead
> {code}
> It looks like the Writer should be created from out rather than baout - otherwise why
create out?
> Similarly for
> testCopy_inputStreamToWriter()
> testCopy_readerToWriter()
> testCopy_stringToWriter()
> The tests still pass if the Writer is changed to use out.
> Thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message