commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MATH-401) Policy concerning "null"
Date Thu, 05 Aug 2010 11:10:16 GMT

    [ https://issues.apache.org/jira/browse/MATH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895646#action_12895646
] 

Gilles commented on MATH-401:
-----------------------------

The policy could be that IAE is thrown when encountering "null" references. Then, do you actually
want to create all possible "informative" messages: "foo cannot be null" , "bar cannot be
null", etc. (i.e. basically as many as there are types)?


> Policy concerning "null"
> ------------------------
>
>                 Key: MATH-401
>                 URL: https://issues.apache.org/jira/browse/MATH-401
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Trivial
>             Fix For: 3.0
>
>
> Following the discussion on the "dev" ML, it appears that it would be fine to not check
for {{null}} references within CM. The JVM will do it anyway so that it is redundant and not
necessary most of the time (i.e. when usage is valid). When it happens, the problem is obvious
enough that the standard {{NullPointerException}} fully describes it, without the need for
additional specific and localized detailed messages.
> Hence we could remove all explicit checks for {{null}}. Or when early failure is preferred,
make the check and throw {{NullPointerException}} (without a message argument).
> Since failed checks are currently reported with an {{IllegalArgumentException}}, the
change is not backward-compatible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message