Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 68344 invoked from network); 3 Jul 2010 22:37:15 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Jul 2010 22:37:15 -0000 Received: (qmail 94913 invoked by uid 500); 3 Jul 2010 22:37:15 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 94777 invoked by uid 500); 3 Jul 2010 22:37:14 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 94769 invoked by uid 99); 3 Jul 2010 22:37:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Jul 2010 22:37:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Jul 2010 22:37:12 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o63Maoki020996 for ; Sat, 3 Jul 2010 22:36:50 GMT Message-ID: <5814211.191211278196610356.JavaMail.jira@thor> Date: Sat, 3 Jul 2010 18:36:50 -0400 (EDT) From: "Sean Mickey (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (LANG-630) mutable.MutableObject defines equals(MutableObject) method and uses Object.equals(Object) In-Reply-To: <18843053.151401277978029799.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LANG-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Mickey updated LANG-630: ----------------------------- Attachment: MutableObject-equals.txt The attached patch file addresses this bug. MutableObject.equals(MutableObject) has been refactored to MutableObject.equals(Object). There are also some minor javadoc cleanups and a little more javadoc information has been added. No changes to MutableObject.hashCode were necessary. MutableObjectTest.java verifies that equals continues to work correctly and also that hashCode continues to work correctly. All unit tests ran successfully. > mutable.MutableObject defines equals(MutableObject) method and uses Object.equals(Object) > ----------------------------------------------------------------------------------------- > > Key: LANG-630 > URL: https://issues.apache.org/jira/browse/LANG-630 > Project: Commons Lang > Issue Type: Bug > Reporter: Sebb > Fix For: 3.0 > > Attachments: MutableObject-equals.txt > > > FIndbugs: > mutable.MutableObject defines equals(MutableObject) method and uses Object.equals(Object) > This class defines a covariant version of the equals() method, but inherits the normal equals(Object) method defined in the base java.lang.Object class. The class should probably define a boolean equals(Object) method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.