commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Mickey (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LANG-630) mutable.MutableObject defines equals(MutableObject) method and uses Object.equals(Object)
Date Sat, 03 Jul 2010 22:36:50 GMT

     [ https://issues.apache.org/jira/browse/LANG-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Mickey updated LANG-630:
-----------------------------

    Attachment: MutableObject-equals.txt

The attached patch file addresses this bug. MutableObject.equals(MutableObject) has been refactored
to MutableObject.equals(Object). There are also some minor javadoc cleanups and a little more
javadoc information has been added.

No changes to MutableObject.hashCode were necessary.

MutableObjectTest.java verifies that equals continues to work correctly and also that hashCode
continues to work correctly. All unit tests ran successfully.

> mutable.MutableObject defines equals(MutableObject) method and uses Object.equals(Object)
> -----------------------------------------------------------------------------------------
>
>                 Key: LANG-630
>                 URL: https://issues.apache.org/jira/browse/LANG-630
>             Project: Commons Lang
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 3.0
>
>         Attachments: MutableObject-equals.txt
>
>
> FIndbugs:
> mutable.MutableObject defines equals(MutableObject) method and uses Object.equals(Object)
> This class defines a covariant version of the equals() method, but inherits the normal
equals(Object) method defined in the base java.lang.Object class.  The class should probably
define a boolean equals(Object) method. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message