commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (NET-328) FromNetASCIIInputStream.read(byte[], int, int) may change length passed to superclass if not doing conversion
Date Sat, 10 Jul 2010 23:20:49 GMT
FromNetASCIIInputStream.read(byte[], int, int) may change length passed to superclass if not
doing conversion
-------------------------------------------------------------------------------------------------------------

                 Key: NET-328
                 URL: https://issues.apache.org/jira/browse/NET-328
             Project: Commons Net
          Issue Type: Bug
    Affects Versions: 2.0
            Reporter: Sebb
            Priority: Minor


The method FromNetASCIIInputStream.read(byte[], int, int) may change the length passed to
superclass if not doing conversion.

It should probably check  _noConversionRequired and call the super-class before recalculating
the length.
That is
{code}
if (_noConversionRequired)
    return super.read(buffer, offset, __length);
{code}
should be done at the very start of the method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message