commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MATH-384) DescriptiveStatistics based on double[]
Date Mon, 26 Jul 2010 10:09:53 GMT

    [ https://issues.apache.org/jira/browse/MATH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892248#action_12892248
] 

Phil Steitz commented on MATH-384:
----------------------------------

Sorry for the delay reviewing this.  The change to ResizeableDoubleArray looks good.  I have
a couple of comments / suggestions for improvement on the patch:
.
1. Lets add DescriptiveStatistics(double[])  as well.

2. We need test cases for the new code.

3. Another useful extension to ResizeableDoubleArray that would lift to DescriptiveStatistics
would be addValues(double[]).

I am fine skipping 3 for now.

> DescriptiveStatistics based on double[]
> ---------------------------------------
>
>                 Key: MATH-384
>                 URL: https://issues.apache.org/jira/browse/MATH-384
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Mikkel Meyer Andersen
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: ResizableArrayInstantiatedByArray
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Right now the DescriptiveStatistics is for ResizableDoubleArray, but if the user has
the double[] data she wishes to get DescriptiveStatistics for there is no way of doing this
(besides the inefficient way of creating a ResizableDoubleArray from the double[]).
> It would be possible to use StatUtils, but it does not contain near as much functionality
as DescriptiveStatistics.
> Idea: Create a DescriptiveStatistics for double[] also. I'm not sure which way of implementing
it would be the best, but one way would be to make DescriptiveStatistics abstract with all
but the apply-method implemented as now. The apply-method should be made as abstract which
then has to implemented in the extensions together with a field containing the values. (addValue,
windowSize etc. has to go in the ResizableDoubleArray-extension.) The double[]-extension should
then have a constructor taking double[] as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message