commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-628) Javadoc for HashCodeBuilder.append(boolean) does not match implementation.
Date Tue, 06 Jul 2010 07:37:51 GMT

    [ https://issues.apache.org/jira/browse/LANG-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885453#action_12885453
] 

Henri Yandell commented on LANG-628:
------------------------------------

I've updated the Javadoc with your text.

> Javadoc for HashCodeBuilder.append(boolean) does not match implementation.
> --------------------------------------------------------------------------
>
>                 Key: LANG-628
>                 URL: https://issues.apache.org/jira/browse/LANG-628
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>            Reporter: Sean Mickey
>            Priority: Minor
>             Fix For: 3.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The Javadoc description for HashCodeBuilder.append(boolean) says that it "adds iConstant
* 1 to the hashCode," however, the code is actually:
> iTotal = iTotal * iConstant + (value ? 0 : 1). It is probably just a typo, but it easy
to correct.
> And the reference to hashCode handling in java.lang.Boolean:  "not a 1231 or 1237 as
done in java.lang.Boolean" could be clarified with more detail. Otherwise, it requires going
to the java.lang Javadoc and finding the java.lang.Boolean.hashCode Javadoc description.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message