Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 68852 invoked from network); 21 Jun 2010 14:01:53 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Jun 2010 14:01:53 -0000 Received: (qmail 80484 invoked by uid 500); 21 Jun 2010 14:01:53 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 80283 invoked by uid 500); 21 Jun 2010 14:01:52 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 80273 invoked by uid 99); 21 Jun 2010 14:01:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jun 2010 14:01:52 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jun 2010 14:01:50 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o5LE1SRH026782 for ; Mon, 21 Jun 2010 14:01:28 GMT Message-ID: <19468638.110001277128888469.JavaMail.jira@thor> Date: Mon, 21 Jun 2010 10:01:28 -0400 (EDT) From: "Phil Steitz (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (MATH-377) weight versus sigma in AbstractLeastSquares In-Reply-To: <4136738.52021276765643826.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MATH-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880832#action_12880832 ] Phil Steitz commented on MATH-377: ---------------------------------- I guess if you assume normalliy distributed errors, it makes sense, so drop the last comment and I am +1 for the change (with definition added to the javadoc). > weight versus sigma in AbstractLeastSquares > ------------------------------------------- > > Key: MATH-377 > URL: https://issues.apache.org/jira/browse/MATH-377 > Project: Commons Math > Issue Type: Bug > Affects Versions: 2.1 > Reporter: Dimitri Pourbaix > Fix For: 2.2 > > Original Estimate: 0.02h > Remaining Estimate: 0.02h > > In AbstractLeastSquares, residualsWeights contains the WEIGHTS assigned to each observation. In the method getRMS(), these weights are multiplicative as they should. unlike in getChiSquare() where it appears at the denominator! If the weight is really the weight of the observation, it should multiply the square of the residual even in the computation of the chi2. > Once corrected, getRMS() can even reduce > public double getRMS() {return Math.sqrt(getChiSquare()/rows);} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.