Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <10756636.68881276441274399.JavaMail.jira@thor>
Date: Sun, 13 Jun 2010 11:01:14 -0400 (EDT)
From: "Chris Lee (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Updated: (CLI-193) StringIndexOutOfBoundsException in
 HelpFormatter.findWrapPos
In-Reply-To: <1528495818.20601264211961544.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CLI-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lee updated CLI-193:
--------------------------

    Attachment: cli-helpformatter-stringIndexOOB.patch

Here is a patch that adds a test case and applies the fix suggested by Travis.

> StringIndexOutOfBoundsException in HelpFormatter.findWrapPos
> ------------------------------------------------------------
>
>                 Key: CLI-193
>                 URL: https://issues.apache.org/jira/browse/CLI-193
>             Project: Commons CLI
>          Issue Type: Bug
>          Components: CLI-1.x
>    Affects Versions: 1.2
>            Reporter: Travis McLeskey
>            Priority: Critical
>             Fix For: 1.3
>
>         Attachments: cli-helpformatter-stringIndexOOB.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> In the last while loop in HelpFormatter.findWrapPos, it can pass text.length() to text.charAt(int), which throws a StringIndexOutOfBoundsException. The first expression in that while loop condition should use a <, not a <=.
> This is on line 908 in r779646:
>   http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/java/org/apache/commons/cli/HelpFormatter.java?revision=779646&view=markup

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.