commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Gansevles (JIRA)" <j...@apache.org>
Subject [jira] Created: (DBCP-337) equals in DelegatingXXX is not reflexive and could be faster
Date Thu, 10 Jun 2010 20:51:38 GMT
equals in DelegatingXXX is not reflexive and could be faster
------------------------------------------------------------

                 Key: DBCP-337
                 URL: https://issues.apache.org/jira/browse/DBCP-337
             Project: Commons Dbcp
          Issue Type: Bug
            Reporter: Rob Gansevles
            Priority: Minor


The equals() methods in the different DelegatingXXX classes do not start with a simple object
equality check for this.
The equals methods do not implement the contract for equals because x.equals(x) where getInnermostDelegate()
for x returns null will return false.
Performance-wise the check would help since you don't need to walk the delegate tree.

I will attach a patch.

Rob


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message