commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luc Maisonobe (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MATH-379) Multidimensional counter
Date Thu, 24 Jun 2010 19:35:50 GMT

    [ https://issues.apache.org/jira/browse/MATH-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882296#action_12882296
] 

Luc Maisonobe commented on MATH-379:
------------------------------------

A few remarks.

The javadoc is very scarce and most methods have no description, only parameters. The class
javadoc can also be understood only if you already know the purpose of the class, so new users
won't get it.

The typical example is getCount in the Iterator class. The name "count" is misleading and
without explanation it took me a long to understand its purpose. Rather than getCount(index),
I would have used getIndex(dimension).

The IllegalArgumentException in the MultidimensionalCounter constructor should be localized.

The util package seems a good fit for this class.

> Multidimensional counter
> ------------------------
>
>                 Key: MATH-379
>                 URL: https://issues.apache.org/jira/browse/MATH-379
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>         Attachments: MultidimensionalCounter.java
>
>
> Utility that converts from indices in a multidimensional structure to the corresponding
index in a one-dimensional array.
> E.g. assuming that the ranges (in 3D) of indices are {2, 4, 3}, we'll have that
>   (0, 0, 0) corresponds to 0
>   (0, 0, 1) corresponds to 1
>     ...
>   (1, 0, 0) corresponds to 12
>     ...
>   (1, 3, 2) corresponds to 23
> I propose to add this class in the "util" package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message