commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COLLECTIONS-312) Minor changes to tidy modifiers for fields, methods and classes.
Date Sat, 19 Jun 2010 20:32:23 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880545#action_12880545
] 

Henri Yandell commented on COLLECTIONS-312:
-------------------------------------------

Thanks Peter.

Patches weren't applying too cleanly after the merge from 4.0, so I've applied some by hand
and still have 1200 lines to go through.

> Minor changes to tidy modifiers for fields, methods and classes.
> ----------------------------------------------------------------
>
>                 Key: COLLECTIONS-312
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-312
>             Project: Commons Collections
>          Issue Type: Improvement
>            Reporter: Peter Lawrey
>            Priority: Trivial
>         Attachments: commons-collections-static-analysis.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> These changes include
> - private/package-local fields final if possible.
> - private/package-local methods and classes static if possible
> - remove fields which can be make local variables.
> See the attached patch for the changes

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message