Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 6223 invoked from network); 22 Apr 2010 09:50:16 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Apr 2010 09:50:16 -0000 Received: (qmail 5391 invoked by uid 500); 22 Apr 2010 09:50:16 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 5089 invoked by uid 500); 22 Apr 2010 09:50:13 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 5081 invoked by uid 99); 22 Apr 2010 09:50:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Apr 2010 09:50:13 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Apr 2010 09:50:10 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o3M9nnqv013735 for ; Thu, 22 Apr 2010 09:49:49 GMT Message-ID: <26307309.135911271929789458.JavaMail.jira@thor> Date: Thu, 22 Apr 2010 05:49:49 -0400 (EDT) From: "Stefan Bodewig (JIRA)" To: issues@commons.apache.org Subject: [jira] Resolved: (COMPRESS-106) ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o) should be deleted In-Reply-To: <13632737.118481271870029623.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COMPRESS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-106. ------------------------------------- Fix Version/s: 1.1 Resolution: Fixed fixed with svn revision 936697 > ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o) should be deleted > ----------------------------------------------------------------------------------- > > Key: COMPRESS-106 > URL: https://issues.apache.org/jira/browse/COMPRESS-106 > Project: Commons Compress > Issue Type: Improvement > Reporter: Sebb > Fix For: 1.1 > > > The method ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o) should be deleted, as it does nothing useful. > The contents are exactly the same as Object.equals(). > If the method is kept, then the class should also override hashCode() for consistency. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.