commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IO-242) Pre- and post-processing support for ProxyReader/Writer
Date Wed, 14 Apr 2010 17:22:48 GMT

    [ https://issues.apache.org/jira/browse/IO-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856966#action_12856966
] 

Niall Pemberton commented on IO-242:
------------------------------------

The only comment I would make is that this proxy can now throw NPE if the String/char[]/CharBuffer
is null - whereas in the past it would have just passed a null on to the delegate Reader/Writer.

I added test cases for nulls:

http://svn.apache.org/viewvc?view=revision&revision=934024

IMO at least for the ProxyWriter then it shouldn't now be throwing a NPE


> Pre- and post-processing support for ProxyReader/Writer
> -------------------------------------------------------
>
>                 Key: IO-242
>                 URL: https://issues.apache.org/jira/browse/IO-242
>             Project: Commons IO
>          Issue Type: New Feature
>          Components: Streams/Writers
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: IO-242.patch
>
>
> In IO-211 we added protected before/after methods for all read and write operations in
ProxyInputStream and ProxyOutputStream. I now have a use case where I need similar functionality
also for a Writer, so I've implemented the same feature also for ProxyReader and ProxyWriter.
I'll attach the patch for review before committing it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message