commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (COMPRESS-106) ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o) should be deleted
Date Thu, 22 Apr 2010 09:49:49 GMT

     [ https://issues.apache.org/jira/browse/COMPRESS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Bodewig resolved COMPRESS-106.
-------------------------------------

    Fix Version/s: 1.1
       Resolution: Fixed

fixed with svn revision 936697

> ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o) should be deleted
> -----------------------------------------------------------------------------------
>
>                 Key: COMPRESS-106
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-106
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 1.1
>
>
> The method ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o) should be
deleted, as it does nothing useful.
> The contents are exactly the same as Object.equals().
> If the method is kept, then the class should also override hashCode() for consistency.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message