commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (POOL-166) GenericKeyedObjectPool.destroy could use entrySet() rather than keySet() followed by get()
Date Fri, 23 Apr 2010 19:00:53 GMT

     [ https://issues.apache.org/jira/browse/POOL-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved POOL-166.
-----------------------

    Fix Version/s: 1.5.5
       Resolution: Fixed

Fixed with slightly amended patch (key variable assigned outside inner loop)

> GenericKeyedObjectPool.destroy could use entrySet() rather than keySet() followed by
get()
> ------------------------------------------------------------------------------------------
>
>                 Key: POOL-166
>                 URL: https://issues.apache.org/jira/browse/POOL-166
>             Project: Commons Pool
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 1.5.5
>
>         Attachments: GenericKeyedObjectPool.patch
>
>
> [Findbugs]
> It would be more efficient if GenericKeyedObjectPool.destroy used entrySet() rather than
keySet() followed by get()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message