commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Wooten (JIRA)" <j...@apache.org>
Subject [jira] Updated: (IO-229) Convert AndFileFilter and OrFileFilter Constructors to Use Varargs
Date Thu, 04 Mar 2010 14:35:27 GMT

     [ https://issues.apache.org/jira/browse/IO-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Wooten updated IO-229:
------------------------------

           Description: 
I suggest converting the AndFileFilter(IOFileFilter filter1, IOFileFilter filter2) and OrFileFilter(IOFileFilter
filter1, IOFileFilter filter2) constructors to use varargs and instead have the signatures
AndFileFilter(IOFileFilter... filters) and OrFileFilter(IOFileFilter... filters). The benefit
is that new And/OrFileFilters could be created without having to create a list or limit the
initial number of filters to two.
Ex: 
IOFileFilter hiddenNonEmptyTextFileFilter = new AndFileFilter(HiddenFileFilter.HIDDEN, EmptyFileFilter.NOT_EMPTY,
new SuffixFileFilter(".txt"));

If backwards compatibility is an issue, then the varargs constructors could be added alongside
the two argument constructors.

  was:
I suggest converting the AndFileFilter(IOFileFilter filter1, IOFileFilter filter2) constructor
to use varargs and instead have the signature AndFileFilter(IOFileFilter... filters). The
benefit is that new AndFileFilters could be created without having to create a list or limit
the initial number of filters to two.
Ex: 
IOFileFilter hiddenNonEmptyTextFileFilter = new AndFileFilter(HiddenFileFilter.HIDDEN, EmptyFileFilter.NOT_EMPTY,
new SuffixFileFilter(".txt"));

    Remaining Estimate: 2h  (was: 0.03h)
     Original Estimate: 2h  (was: 0.03h)
               Summary: Convert AndFileFilter and OrFileFilter Constructors to Use Varargs
 (was: Convert AndFileFilter Constructor to Use Varargs)

> Convert AndFileFilter and OrFileFilter Constructors to Use Varargs
> ------------------------------------------------------------------
>
>                 Key: IO-229
>                 URL: https://issues.apache.org/jira/browse/IO-229
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Filters
>    Affects Versions: 2.0
>         Environment: Java 1.5+
>            Reporter: Michael Wooten
>            Priority: Minor
>             Fix For: 2.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I suggest converting the AndFileFilter(IOFileFilter filter1, IOFileFilter filter2) and
OrFileFilter(IOFileFilter filter1, IOFileFilter filter2) constructors to use varargs and instead
have the signatures AndFileFilter(IOFileFilter... filters) and OrFileFilter(IOFileFilter...
filters). The benefit is that new And/OrFileFilters could be created without having to create
a list or limit the initial number of filters to two.
> Ex: 
> IOFileFilter hiddenNonEmptyTextFileFilter = new AndFileFilter(HiddenFileFilter.HIDDEN,
EmptyFileFilter.NOT_EMPTY, new SuffixFileFilter(".txt"));
> If backwards compatibility is an issue, then the varargs constructors could be added
alongside the two argument constructors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message