commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] Commented: (MATH-349) Dangerous code in "PoissonDistributionImpl"
Date Tue, 09 Mar 2010 14:08:27 GMT


Gilles commented on MATH-349:

The same kind of problem also exists in "".
In both classes, the constructor that takes the distribution as a parameter has been deprecated.

> Dangerous code in "PoissonDistributionImpl"
> -------------------------------------------
>                 Key: MATH-349
>                 URL:
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Gilles
>            Priority: Minor
> In the following excerpt from class "PoissonDistributionImpl":
> {|borderStyle=solid}
>     public PoissonDistributionImpl(double p, NormalDistribution z) {
>         super();
>         setNormal(z);
>         setMean(p);
>     }
> {code}
> (1) Overridable methods are called within the constructor.
> (2) The reference "z" is stored and modified within the class.
> I've encountered problem (1) in several classes while working on issue 348. In those
cases, in order to remove potential problems, I copied/pasted the body of the "setter" methods
inside the constructor but I think that a more elegant solution would be to remove the "setters"
altogether (i.e. make the classes immutable).
> Problem (2) can also create unexpected behaviour. Is it really necessary to pass the
"NormalDistribution" object; can't it be always created within the class?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message