commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shaun Elliott (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-600) Javadoc is incorrect for public static int lastIndexOf(String str, String searchStr)
Date Fri, 05 Mar 2010 18:54:27 GMT

    [ https://issues.apache.org/jira/browse/LANG-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841972#action_12841972
] 

Shaun Elliott commented on LANG-600:
------------------------------------

I can confirm this. 

Running the following:

		// Copied from the javadoc      
		System.out.println( StringUtils.lastIndexOf( null, "*" ) );
		System.out.println( StringUtils.lastIndexOf( "*", null ) );
		System.out.println( StringUtils.lastIndexOf( "", "" ) );
		System.out.println( StringUtils.lastIndexOf( "aabaabaa", "a" ) );
		System.out.println( StringUtils.lastIndexOf( "aabaabaa", "b" ) );
		System.out.println( StringUtils.lastIndexOf( "aabaabaa", "ab" ) );
		System.out.println( StringUtils.lastIndexOf( "aabaabaa", "" ) );

Yields this:
-1
-1
0
7
5
4
8

Not this (as presented in the javadoc):
-1
-1
0
0
2
1
8

> Javadoc is incorrect for public static int lastIndexOf(String str, String searchStr)
> ------------------------------------------------------------------------------------
>
>                 Key: LANG-600
>                 URL: https://issues.apache.org/jira/browse/LANG-600
>             Project: Commons Lang
>          Issue Type: Task
>          Components: lang.*
>    Affects Versions: 2.4
>            Reporter: Sean Montgomery
>            Priority: Trivial
>
> The javadoc's examples show how indexOf should work not lastIndexOf.
>  StringUtils.lastIndexOf(null, *)          = -1
>  StringUtils.lastIndexOf(*, null)          = -1
>  StringUtils.lastIndexOf("", "")           = 0
>  StringUtils.lastIndexOf("aabaabaa", "a")  = 0
>  StringUtils.lastIndexOf("aabaabaa", "b")  = 2
>  StringUtils.lastIndexOf("aabaabaa", "ab") = 1
>  StringUtils.lastIndexOf("aabaabaa", "")   = 8

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message