commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Heger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CONFIGURATION-410) Include forceReload or refresh method in AbstractFileConfiguration
Date Sat, 13 Mar 2010 20:38:27 GMT

    [ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844961#action_12844961
] 

Oliver Heger commented on CONFIGURATION-410:
--------------------------------------------

Thanks for your patch. I had a look and understand how the feature is implemented. Some comments
below:

* At least in minor releases we have to keep backwards compatibility to avoid breaking existing
code. So we must not change the signature of public or protected methods or reduce method
visibility.
* Was there a special reason why in the catch(Exception) block the if-statement was dropped?
* Is there any chance that you can provide a JUnit test? We usually only add new features
if a unit test exists. If not, I can write a test myself.

> Include forceReload or refresh method in AbstractFileConfiguration 
> -------------------------------------------------------------------
>
>                 Key: CONFIGURATION-410
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
>             Project: Commons Configuration
>          Issue Type: Improvement
>          Components: File reloading
>            Reporter: Bhanu Vanteru
>            Priority: Minor
>         Attachments: AbstractFileConfiguration.diff, AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload()
or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired()
is ignored and so a clear() and load() always occur when this new method is called. I will
upload changes to AbstractFileConfiguration with this new method in a bit, for your review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message