commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brent W. (JIRA)" <j...@apache.org>
Subject [jira] Closed: (NET-311) FTPClient.protected Socket _openDataConnection_(int command, String arg) returns null
Date Fri, 05 Mar 2010 00:35:27 GMT

     [ https://issues.apache.org/jira/browse/NET-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brent W. closed NET-311.
------------------------


After compiling the library on my own and doing some debugging, I realized this.  Sorry to
have troubled you.

> FTPClient.protected Socket _openDataConnection_(int command, String arg) returns null
> -------------------------------------------------------------------------------------
>
>                 Key: NET-311
>                 URL: https://issues.apache.org/jira/browse/NET-311
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 2.0
>         Environment: Windows XP, but I would think not platform specific.
>            Reporter: Brent W.
>            Priority: Minor
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
>     protected Socket _openDataConnection_(int command, String arg)
>       throws IOException
>     {
>         Socket socket;
>         if (__dataConnectionMode != ACTIVE_LOCAL_DATA_CONNECTION_MODE &&
>                 __dataConnectionMode != PASSIVE_LOCAL_DATA_CONNECTION_MODE)
>             return null;
>         ....
>      }
> This if condition is impossible to satisfy.  Should be OR(||) instead of AND(&&).
> __dataConnectionMode can not be set to 2 & 0 at the same time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message