Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 16956 invoked from network); 15 Feb 2010 04:45:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Feb 2010 04:45:52 -0000 Received: (qmail 74771 invoked by uid 500); 15 Feb 2010 04:45:51 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 74674 invoked by uid 500); 15 Feb 2010 04:45:51 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 74664 invoked by uid 99); 15 Feb 2010 04:45:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Feb 2010 04:45:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Feb 2010 04:45:49 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 27CBA29A001C for ; Sun, 14 Feb 2010 20:45:28 -0800 (PST) Message-ID: <911262563.271101266209128161.JavaMail.jira@brutus.apache.org> Date: Mon, 15 Feb 2010 04:45:28 +0000 (UTC) From: "Phil Steitz (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (DBCP-317) Findbugs: Class doesn't override equals in superclass In-Reply-To: <1624343274.34621262659014497.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DBCP-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated DBCP-317: ----------------------------- Fix Version/s: (was: 1.4) 1.4.1 1.3.1 > Findbugs: Class doesn't override equals in superclass > ----------------------------------------------------- > > Key: DBCP-317 > URL: https://issues.apache.org/jira/browse/DBCP-317 > Project: Commons Dbcp > Issue Type: Bug > Affects Versions: 1.4 > Reporter: Sebb > Priority: Minor > Fix For: 1.3.1, 1.4.1 > > > Findbugs: Class doesn't override equals in superclass - 8 instances > "This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o). " > Classes (superclass) are: > cpdsadapter.ConnectionImpl doesn't override DelegatingConnection.equals > datasources.LRUMap doesn't override SequencedHashMap.equals > managed.ManagedConnection doesn't override DelegatingConnection.equals > managed.PoolableManagedConnection doesn't override DelegatingConnection.equals > PoolableCallableStatement doesn't override DelegatingCallableStatement.equals > PoolableConnection doesn't override DelegatingConnection.equals > PoolablePreparedStatement doesn't override DelegatingPreparedStatement.equals > PoolingConnection doesn't override DelegatingConnection.equals -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.