Return-Path: 
 <issues-return-11791-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: (qmail 34196 invoked from network); 7 Feb 2010 05:22:52 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 7 Feb 2010 05:22:52 -0000
Received: (qmail 46072 invoked by uid 500); 7 Feb 2010 05:22:52 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 45798 invoked by uid 500); 7 Feb 2010 05:22:51 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 45788 invoked by uid 99); 7 Feb 2010 05:22:51 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Feb 2010 05:22:51 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Feb 2010 05:22:49 +0000
Received: from brutus.apache.org (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 21B0F234C4A8
	for <issues@commons.apache.org>; Sat,  6 Feb 2010 21:22:28 -0800 (PST)
Message-ID: <1397072746.104901265520148136.JavaMail.jira@brutus.apache.org>
Date: Sun, 7 Feb 2010 05:22:28 +0000 (UTC)
From: "Henri Yandell (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (LANG-588) Create a basic Pair<L, R> class
In-Reply-To: <931649863.99721265489127975.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/LANG-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830653#action_12830653 ] 

Henri Yandell commented on LANG-588:
------------------------------------

It was for IP sake - I wrote it as an exercise instead of for any use. Happy to use yours instead.

Comments on your patches:

* Javadoc for pairOf/matchedPairOf needs filling in.
* @since should be '3.0' and not 'Lang 3.0'
* The static import in the tests makes me cringe, but I know you like using them. First time I looked at the code (as I looked at tests first) I went looking in the file to see where the utility pairOf method was, while wondering why you'd done such a thing.
* I'm not sure about the Iterable concept for MatchedPair.
* I do like the notion of Iterable if it becomes a tree walker - i.e. it iterates down Pairs of Pairs. It could then be in the parent and could be:  depthFirstIterate() & breadthFirstIterate().

> Create a basic Pair<L, R> class
> -------------------------------
>
>                 Key: LANG-588
>                 URL: https://issues.apache.org/jira/browse/LANG-588
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>            Reporter: Matt Benson
>             Fix For: 3.0
>
>         Attachments: MatchedPair.java, MatchedPairTest.java, Pair.java, PairTest.java
>
>
> [lang] is the perfect place to provide a basic typed Pair class.  I have written such a class for my employer (who hasn't?) but can/will rewrite blind to avoid IP issues.  I think it's also nice to go ahead and extend this to MatchedPair<T> extends Pair<T, T> as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.