Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 62390 invoked from network); 11 Feb 2010 19:20:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Feb 2010 19:20:51 -0000 Received: (qmail 51210 invoked by uid 500); 11 Feb 2010 19:20:50 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 51117 invoked by uid 500); 11 Feb 2010 19:20:50 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 51107 invoked by uid 99); 11 Feb 2010 19:20:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2010 19:20:50 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2010 19:20:49 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A564329A0014 for ; Thu, 11 Feb 2010 11:20:29 -0800 (PST) Message-ID: <1277031188.213561265916029676.JavaMail.jira@brutus.apache.org> Date: Thu, 11 Feb 2010 19:20:29 +0000 (UTC) From: "Mladen Turk (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (DAEMON-128) Default DaemonController implementation has empty fail() method bodies In-Reply-To: <211117109.1250508494815.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DAEMON-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832643#action_12832643 ] Mladen Turk commented on DAEMON-128: ------------------------------------ >Please either make these throw UnsupportedOpperationException and document them appropriately, or better yet, actually implement them. Feel free to provide a patches :) In the mean time I'll mark the issue as feature request, not bug since there were no explanation why would that make a problem > Default DaemonController implementation has empty fail() method bodies > ---------------------------------------------------------------------- > > Key: DAEMON-128 > URL: https://issues.apache.org/jira/browse/DAEMON-128 > Project: Commons Daemon > Issue Type: Bug > Affects Versions: 1.0.1 > Environment: Fedora Core 10 > Reporter: David North > > As per http://svn.apache.org/viewvc/commons/proper/daemon/trunk/src/java/org/apache/commons/daemon/support/DaemonLoader.java?revision=560660, the fail() methods on the default (and only provided) implementation of the DaemonController interface have empty bodies. This means that calling them does nothing and returns normally, which is the complete opposite of the desired behaviour. > Please either make these throw UnsupportedOpperationException and document them appropriately, or better yet, actually implement them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.