commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-585) exception.DefaultExceptionContext.getFormattedExceptionMessage catches Throwable
Date Wed, 03 Feb 2010 11:43:28 GMT

    [ https://issues.apache.org/jira/browse/LANG-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829037#action_12829037
] 

Sebb commented on LANG-585:
---------------------------

Also fixed Javadoc that referred to Throwable:

URL: http://svn.apache.org/viewvc?rev=906015&view=rev
Log:
LANG-585. Don't suggest catching Throwable, catch Exception instead.

Modified:
   commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedException.java
   commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedRuntimeException.java


> exception.DefaultExceptionContext.getFormattedExceptionMessage catches Throwable
> --------------------------------------------------------------------------------
>
>                 Key: LANG-585
>                 URL: https://issues.apache.org/jira/browse/LANG-585
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.exception.*
>            Reporter: Sebb
>             Fix For: 3.0
>
>
> It's generally a bad idea to catch Throwable.
> The getFormattedExceptionMessage method should be changed to catch less; e.g. Exception
+ RuntimeException should be adequate.
> The Javadoc examples in ContextedException and ContextedRuntimeException suggest catching
Throwable; these examples should be changed too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message