commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Closed: (LANG-534) ArrayUtils should have method to convert null arrays to empty ones to help with Defensive coding
Date Wed, 03 Feb 2010 07:55:19 GMT

     [ https://issues.apache.org/jira/browse/LANG-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell closed LANG-534.
------------------------------

    Resolution: Fixed

Original patch applied.

svn ci -m "Adding nullToEmpty methods to ArrayUtils per LANG-534 and Levon Karayan's patch.
"
Sending        src/main/java/org/apache/commons/lang3/ArrayUtils.java
Sending        src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
Transmitting file data ..
Committed revision 905925.


> ArrayUtils should have method to convert null arrays to empty ones to help with Defensive
coding
> ------------------------------------------------------------------------------------------------
>
>                 Key: LANG-534
>                 URL: https://issues.apache.org/jira/browse/LANG-534
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>            Reporter: Levon Karayan
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: 20090920LevonArrayUtils-nullToEmpty.patch
>
>
> There are APIs that I've come across that return <code>null</code> Arrays
in the event where there are no results.  Often these APIs correctly throw exceptions when
there is an "exceptional event", but no results isn't exceptional, and it often shouldn't
be.   This causes the programmer to make extra tests for null throughout the code to deal
with the null case, and sometimes these null cases are added after a customer searched for
gobleygook and got a NullPointerException.  It's just far cleaner/safer to convert these null
arrays to empty arrays.
> Another benefit to this method is that if the array being passed in is actually already
an empty array, it will swap the pointer for the <code>static final</code> in
the ArrayUtils class to help decrease memory fragmentation.
> e.g.
> BEFORE:
> try
> {
>   results = customer.getResults(query);
> } catch ( IOException ioex ) {
>   //  ...
> }
> if ( null == results )
> {
>    results = new int[0]{};
> }
> // do stuff
> AFTER
> try
> {
>   results = ArrayUtils.nullToEmpty(customer.getResults(query));
> } catch ( IOException ioex ) {
>   //  ...
> }
> // do stuff

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message