commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CONFIGURATION-407) HierarchicalINIConfiguration can throw an exception if the global section is accessed concurrently
Date Tue, 09 Feb 2010 21:33:27 GMT

    [ https://issues.apache.org/jira/browse/CONFIGURATION-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831679#action_12831679
] 

Sebb commented on CONFIGURATION-407:
------------------------------------

I think the user guide needs to be a lot clearer about what manual synch. is required. What
should the reader threads synchronize on?

Thread-safety and correct publication is only guaranteed if the writer and reader threads
use the *same* lock, so the reader thread needs to know what lock to use.


> HierarchicalINIConfiguration can throw an exception if the global section is accessed
concurrently
> --------------------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-407
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-407
>             Project: Commons Configuration
>          Issue Type: Bug
>    Affects Versions: 1.6
>            Reporter: Oliver Heger
>            Assignee: Oliver Heger
>             Fix For: 1.7
>
>
> If the global section of a hierarchical INI configuration is requested, a new ViewNode
is created which becomes the root node of a new configuration for the global section. Nodes
representing properties of the global section are added to this ViewNode. This operation temporarily
changes the parent node of these nodes which may cause problems if the method is called by
multiple threads concurrently. Because access to a section is a read-only operation, this
should be thread-safe.
> The probability that this error happens is pretty low IMO. Therefore it should be hard
to create a unit test.
> The issue can be fixed by synchronizing the add operation to the ViewNode.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message