Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 56660 invoked from network); 2 Jan 2010 05:02:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 2 Jan 2010 05:02:18 -0000 Received: (qmail 3749 invoked by uid 500); 2 Jan 2010 05:02:17 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 3640 invoked by uid 500); 2 Jan 2010 05:02:17 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 3630 invoked by uid 99); 2 Jan 2010 05:02:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Jan 2010 05:02:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Jan 2010 05:02:15 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6C4C9234C1F1 for ; Fri, 1 Jan 2010 21:01:54 -0800 (PST) Message-ID: <951829163.3441262408514442.JavaMail.jira@brutus.apache.org> Date: Sat, 2 Jan 2010 05:01:54 +0000 (UTC) From: "Henri Yandell (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (LANG-491) ExceptionUtils + ExceptionUtilsTest needs an overhaul In-Reply-To: <1619293246.1237082210483.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LANG-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795821#action_12795821 ] Henri Yandell commented on LANG-491: ------------------------------------ Removed private getCauseUsingWellKnownTypes and dropping the optimization step for SQLException and InvocationTargetException; plus a simplification of the code in getCause(String,String[]). This does mean a slight change in behaviour - instanceof SQLException (and InvocationTargetException) were always checked regardless of what you passed in as method names. I view that as a bug, so happy to see it go away. > ExceptionUtils + ExceptionUtilsTest needs an overhaul > ----------------------------------------------------- > > Key: LANG-491 > URL: https://issues.apache.org/jira/browse/LANG-491 > Project: Commons Lang > Issue Type: Sub-task > Components: lang.exception.* > Reporter: Henri Yandell > Fix For: 3.0 > > > With the nested stuff removed, ExceptionUtils and its test class are carrying some baggage. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.