Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 99782 invoked from network); 5 Jan 2010 21:20:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Jan 2010 21:20:16 -0000 Received: (qmail 58974 invoked by uid 500); 5 Jan 2010 21:20:15 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 58864 invoked by uid 500); 5 Jan 2010 21:20:15 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 58854 invoked by uid 99); 5 Jan 2010 21:20:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 21:20:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 21:20:14 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 81ACB234C04C for ; Tue, 5 Jan 2010 13:19:54 -0800 (PST) Message-ID: <772788272.53491262726394529.JavaMail.jira@brutus.apache.org> Date: Tue, 5 Jan 2010 21:19:54 +0000 (UTC) From: "Alex Vigdor (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (SANSELAN-35) IPTCParser fails after encountering record number 1 In-Reply-To: <1491194788.53471262726178367.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SANSELAN-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Vigdor updated SANSELAN-35: -------------------------------- Attachment: SANSELAN-35.patch 2010-01-04T052300Z_01_BTRE6021PS000_RTROPTP_3_BUSINESS-US-TSE.JPG The JPG file demonstrates the bug - use ImageMagick, Photoshop or an other tool and see valid IPTC metadata, but Sanselan misses it. After applying the attached patch, Sanselan does find the metadata in the JPG. > IPTCParser fails after encountering record number 1 > --------------------------------------------------- > > Key: SANSELAN-35 > URL: https://issues.apache.org/jira/browse/SANSELAN-35 > Project: Commons Sanselan > Issue Type: Bug > Reporter: Alex Vigdor > Priority: Minor > Attachments: 2010-01-04T052300Z_01_BTRE6021PS000_RTROPTP_3_BUSINESS-US-TSE.JPG, SANSELAN-35.patch > > > IPTCParser fails to find valid metadata in a JPEG after it encounters a record number 1 (it only extracts metadata from records numbered 2). A little debugging showed that this is because it was not properly moving the buffer pointer to the end of the record to pick up subsequent valid records - moving the record number check after the pointer update fixes the problem. I will attach a patch and sample image. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.