commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-565) Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
Date Fri, 01 Jan 2010 17:31:54 GMT

    [ https://issues.apache.org/jira/browse/LANG-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795775#action_12795775
] 

Henri Yandell commented on LANG-565:
------------------------------------

Even if used from multiple threads, I don't see StrSubstitutor being an object shared among
multiple classes. Within the one class it's not that hard to use an object that doesn't demand
thread safety in a thread safe way, and the setXxx methods are quite obviously going to hurt
thread safety.

I suggest WONTFIX.

> Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
> -------------------------------------------------------------------------------------------------
>
>                 Key: LANG-565
>                 URL: https://issues.apache.org/jira/browse/LANG-565
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.text.*
>            Reporter: Sebb
>
> Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
> If these setters could be dropped, the instance variables could be made final.
> I think this would then make the class thread-safe, provided that the Map used by StrLookup
is thread-safe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message