commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-491) ExceptionUtils + ExceptionUtilsTest needs an overhaul
Date Sat, 02 Jan 2010 00:07:54 GMT

    [ https://issues.apache.org/jira/browse/LANG-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795805#action_12795805
] 

Henri Yandell commented on LANG-491:
------------------------------------

Starting to look at the code.

public boolean isThrowableNested() should be deleted. It is always true above JDK 1.4. This
also means that isNestedThrowable should also be deleted, it's also always true above JDK
1.4.

getFullStackTrace then makes little sense. In 1.4+ it only ever prints one item.

All three removed in r895097.

> ExceptionUtils + ExceptionUtilsTest needs an overhaul
> -----------------------------------------------------
>
>                 Key: LANG-491
>                 URL: https://issues.apache.org/jira/browse/LANG-491
>             Project: Commons Lang
>          Issue Type: Sub-task
>          Components: lang.exception.*
>            Reporter: Henri Yandell
>             Fix For: 3.0
>
>
> With the nested stuff removed, ExceptionUtils and its test class are carrying some baggage.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message