commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (DBCP-319) Make private fields final where possible
Date Thu, 07 Jan 2010 00:26:54 GMT
Make private fields final where possible
----------------------------------------

                 Key: DBCP-319
                 URL: https://issues.apache.org/jira/browse/DBCP-319
             Project: Commons Dbcp
          Issue Type: Improvement
            Reporter: Sebb


Several private fields could be made final:

AbandonedTrace.config
AbandonedTrace.AbandonedObjectException._createdTime

cpdsadapter.PooledConnectionImpl:
* connection
* delegatingConnection
* eventListeners
* statementEventListeners
* pstmtPool is protected, but could probably be made final if it were not for the API change
that would imply

cpdsadapter.PooledConnectionImpl.PStmtKey (nested class, variables are protected, but might
as well be private)
* all of its fields could be made final

datasources.[Keyed]CPDSConnectionFactory.validatingMap
datasources.[Keyed]CPDSConnectionFactory.pcMap

managed.PoolableManagedConnection.transactionRegistry
managed.PoolableManagedConnectionFactory.transactionRegistry

managed.TransactionRegistry.transactionManager|caches|xaResources
.AbandonedObjectPool.config|trace

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message