commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DBCP-323) CPDSConnectionFactory fields _password and _username should be final
Date Fri, 22 Jan 2010 14:47:21 GMT

    [ https://issues.apache.org/jira/browse/DBCP-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803715#action_12803715
] 

Sebb commented on DBCP-323:
---------------------------

I see. 

On looking again at the proposed patch, I'm not sure I like it - will comment on DBCP-8.

> CPDSConnectionFactory fields _password and _username should be final
> --------------------------------------------------------------------
>
>                 Key: DBCP-323
>                 URL: https://issues.apache.org/jira/browse/DBCP-323
>             Project: Commons Dbcp
>          Issue Type: Improvement
>            Reporter: Sebb
>
> The fields _password and _username in CPDSConnectionFactory should be final.
> They are set by the ctor, and not changed by the class. Indeed if they are changed, it
would probably cause problems.
> The containing class is package-protected, so it is clearly not intended to be sub-classed
by external clients.
> Therefore it should be OK to make the fields final?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message