commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Closed: (COLLECTIONS-350) MapUtils.getNumber sends output to System.out
Date Fri, 15 Jan 2010 16:48:54 GMT

     [ https://issues.apache.org/jira/browse/COLLECTIONS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell closed COLLECTIONS-350.
-------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 4.0)
                       (was: 4.x)
                       (was: 3.2)

logInfo removed. Thanks Michael.

I looked for other System.out instances in the main java tree and the only other one was intended.

> MapUtils.getNumber sends output to System.out
> ---------------------------------------------
>
>                 Key: COLLECTIONS-350
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-350
>             Project: Commons Collections
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Michael Akerman
>            Priority: Minor
>             Fix For: 4.0-beta-1
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> MapUtils.getNumber calls "logInfo" on a ParseException and it produces output on the
System.out, instead of just returning "null" as the documentation states.
> Since the expected behavior is to return null, *not* print to System.out.  I recommend
we remove the call to logInfo and/or remove the System.out.println inside it.
> At minimum, if that's not agreed upon, the "side-effect" of writing to System.out should
be documented.
> I'm happy to offer code for either of these fixes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message