commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maarten Coene (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (LANG-470) Add containsAll methods to ArrayUtils
Date Sat, 09 Jan 2010 22:33:54 GMT

     [ https://issues.apache.org/jira/browse/LANG-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Maarten Coene reopened LANG-470:
--------------------------------


Sorry but I don't agree on this one.

If the code you provided is the reason to not implement his, you should remove a lot of other
utility methods as well from ArrayUtils and other *Utils classes.
In addition, your code will throw a NPE if one of the passed in arrays are null. The "one-line
code" becomes a bit more complex to handle this situation properly.

Maarten

> Add containsAll methods to ArrayUtils
> -------------------------------------
>
>                 Key: LANG-470
>                 URL: https://issues.apache.org/jira/browse/LANG-470
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>    Affects Versions: 2.4
>            Reporter: Maarten Coene
>             Fix For: 3.0
>
>         Attachments: ArrayUtilsContainsAll.pat
>
>
> The ArrayUtils class contains several "contains" methods.
> It could be usefull to add the corresponding containsAll(Object[] array1, Object[] array2)
methods (and corresponding for primitive types).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message