commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DBCP-322) CPDSConnectionFactory.validateObject(Object) ignores Throwable
Date Fri, 22 Jan 2010 14:43:21 GMT

    [ https://issues.apache.org/jira/browse/DBCP-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803713#action_12803713
] 

Phil Steitz commented on DBCP-322:
----------------------------------

Agree this is excessive.  Need to look carefully at each instance.

> CPDSConnectionFactory.validateObject(Object) ignores Throwable
> --------------------------------------------------------------
>
>                 Key: DBCP-322
>                 URL: https://issues.apache.org/jira/browse/DBCP-322
>             Project: Commons Dbcp
>          Issue Type: Bug
>            Reporter: Sebb
>
> CPDSConnectionFactory.validateObject(Object) catches and ignores Throwable, which is
a bit excessive. For example:
> {code}
> if (rset != null) {
>     try {
>         rset.close();
>     } catch (Throwable t) {
>         // ignore
>     }
> }
> {code}
> close() can only throw SQLException, and that is all that should be ignored. In particular,
ThreadDeath should never be ignored.
> Same applies to KeyedCPDSConnectionFactory.
> Basic[Managed]Datasource also catch Throwable, but rethrow it as SQLNestedException.
> This is a bit better, but there's still the problem with ThreadDeath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message