Return-Path: 
 <issues-return-11128-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: (qmail 14078 invoked from network); 24 Dec 2009 06:49:57 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 24 Dec 2009 06:49:57 -0000
Received: (qmail 85410 invoked by uid 500); 24 Dec 2009 06:49:56 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 85304 invoked by uid 500); 24 Dec 2009 06:49:56 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 85294 invoked by uid 99); 24 Dec 2009 06:49:56 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Dec 2009 06:49:56 +0000
X-ASF-Spam-Status: No, hits=-10.5 required=5.0
	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Dec 2009 06:49:49 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id A5A48234C04C
	for <issues@commons.apache.org>; Wed, 23 Dec 2009 22:49:29 -0800 (PST)
Message-ID: <617402742.1261637369664.JavaMail.jira@brutus>
Date: Thu, 24 Dec 2009 06:49:29 +0000 (UTC)
From: "Henri Yandell (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (LANG-564) StrLookup API is confused
In-Reply-To: <1564600493.1260803058297.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/LANG-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794333#action_12794333 ] 

Henri Yandell commented on LANG-564:
------------------------------------

Agreed that this is confused. I think we should roll back the generics changes.

> StrLookup API is confused
> -------------------------
>
>                 Key: LANG-564
>                 URL: https://issues.apache.org/jira/browse/LANG-564
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.text.*
>            Reporter: Sebb
>             Fix For: 3.0
>
>
> The API for StrLookup is confused. The class has been partly genericised, but why?
> The Javadoc says the class is for looking up Strings which are indexed by Strings, and this agrees with the method lookup()
> Surely if the class is generic on <V>, the lookup() method should return V, not String?
> Does it make any sense for the class to return anything but a String? If not, then why is the class generic?
> If it does make sense, then lookup() should return V.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.