Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 13921 invoked from network); 24 Dec 2009 06:49:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Dec 2009 06:49:54 -0000 Received: (qmail 84997 invoked by uid 500); 24 Dec 2009 06:49:54 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 84749 invoked by uid 500); 24 Dec 2009 06:49:53 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 84368 invoked by uid 99); 24 Dec 2009 06:49:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Dec 2009 06:49:52 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Dec 2009 06:49:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 2C6EA234C495 for ; Wed, 23 Dec 2009 22:49:30 -0800 (PST) Message-ID: <1796116159.1261637370180.JavaMail.jira@brutus> Date: Thu, 24 Dec 2009 06:49:30 +0000 (UTC) From: "Henri Yandell (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (LANG-482) Enhance StrSubstitutor to support nested ${var-${subvr}} expansion In-Reply-To: <1467563774.1233926760096.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LANG-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794335#action_12794335 ] Henri Yandell commented on LANG-482: ------------------------------------ Did you ever get a chance to hit this Rob? > Enhance StrSubstitutor to support nested ${var-${subvr}} expansion > ------------------------------------------------------------------ > > Key: LANG-482 > URL: https://issues.apache.org/jira/browse/LANG-482 > Project: Commons Lang > Issue Type: Improvement > Components: lang.text.* > Reporter: Rob Walker > Priority: Minor > Fix For: 3.0 > > Attachments: StrSubstitutor.java.nested.patch > > > t would be really handy of StrSubstitutor could support nested variable interpolation: > org.osgi.framework.system.packages=org.osgi.framework; version=1.4.0, \ > org.osgi.service.packageadmin; version=1.2.0, \ > org.osgi.service.startlevel; version=1.1.0, \ > org.osgi.service.url; version=1.0.0, \ > org.osgi.util.tracker; version=1.3.3 \ > ${jre-${java.specification.version}} > The process being to expand innermost variable references first and work outwards - this allows for very advance config, such as the above, which can dynamically detect the Java version and expand a JRE version specific property into the property being defined. > Looking at the implementation, it seems it might be a fairly straightforward enhancement to: > private int substitute(StrBuilder buf, int offset, int length, List priorVariables) > The code already has the cyclic map in place. > I already have code that achieves this within Apache Felix, so I will see if I can retro-fit a similar model to the above and if so submit a patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.