commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Lundberg (JIRA)" <>
Subject [jira] Closed: (LOGGING-47) [logging][PATCH] Improvements to wrapper classes
Date Tue, 29 Dec 2009 22:15:30 GMT


Dennis Lundberg closed LOGGING-47.

       Resolution: Fixed
    Fix Version/s: 1.1.0

The Javadoc improvements where commited by rdonkin prior to the 1.1.0 release.

> [logging][PATCH] Improvements to wrapper classes
> ------------------------------------------------
>                 Key: LOGGING-47
>                 URL:
>             Project: Commons Logging
>          Issue Type: Bug
>         Environment: Operating System: All
> Platform: All
>            Reporter: Boris Unckel
>             Fix For: 1.1.0
>         Attachments: AvalonLogger_Patch.txt, jclimpl.patch, jclimpl.patch, Jdk13LumberjackLogger_Patch.txt,
Jdk14Logger_Patch.txt, Log4J12Logger_Patch.txt, Log4J13Logger_Patch.txt, LogKitLogger_Patch.txt,
> There are several issues with the wrapper classes.
> 1) Logging null objects or not
> If the message object is null, the logger logs the String "NULL" to the
> underlying log system. Currently some wrappers just return and some log the
> String "NULL".
> -> The patch unifies that. All wrappers will log the String "NULL".
> 2) Exception safe toString
> Currently all wrappers would fail if an toString method throws a
> RuntimeException. See
> for details.
> -> The patch logs an error message instead and an additional log record with
> the exception in a central, private doLog method.
> 3) isLoggable check
> Currently some wrappers check the log level in each log method and some wrappers
> check the level in one central method, which applies the log message and
> throwable to the underlying log system.
> -> The patch unifies that. All wrappers will use a doLog method and check the
> level there. One exception: AvalonLogger which has no Level/Priority object.
> 3) JavaDoc
> Every wrapper has its own javadoc for the log methods, sometime with reference
> to the Log interface, sometimes with the underlying log level, ...
> -> The patch unifies that. All wrapper log methods are commented in the same way.
> 4) Additional class
> There is one additional class for the error message, to have a single point of
> change.
> Please check the patch for correct format.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message