Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <678120449.1259425880707.JavaMail.jira@brutus>
Date: Sat, 28 Nov 2009 16:31:20 +0000 (UTC)
From: "Niall Pemberton (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Updated: (DBCP-310) SQLNestedException & use of initCause()
 with SQLException
In-Reply-To: <2040562664.1259425760632.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DBCP-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated DBCP-310:
---------------------------------

      Description: 
SQLNestedException in its current state is a hangover from supporting JDK 1.3 when there was no "initCause()" method. This implementation can now be greatly simplified with DBCP now having a minimum of JDK 1.4

Also SQLNestedException is deprecated and the following code has been used in a number of places

{code}
     throw (SQLException )new SQLException(message).initCause(e)
{code}

DBCP is inconsistent though - sometimes using the above and sometimes using SQLNestedException. IMO SQLNestedException  should be un-deprecated and used consistently everywhere - its now a simple implementation and I think the code is cleaner using it rather than the above.

  was:
SQLNestedException in its current state is a hangover from supporting JDK 1.3 when there was no "initCause()" method. This implementation can now be greatly simplified with DBCP now having a minimum of JDK 1.4

Also SQLNestedException is deprecated and the following code has been used in a number of places

{code}
     (SQLException )new SQLException(message).initCause(e)
{code}

DBCP is inconsistent though - sometimes using the above and sometimes using SQLNestedException. IMO SQLNestedException  should be un-deprecated and used consistently everywhere - its now a simple implementation and I think the code is cleaner using it rather than the above.

         Priority: Minor  (was: Major)
    Fix Version/s: 1.4
                   1.3

> SQLNestedException & use of initCause() with SQLException
> ---------------------------------------------------------
>
>                 Key: DBCP-310
>                 URL: https://issues.apache.org/jira/browse/DBCP-310
>             Project: Commons Dbcp
>          Issue Type: Improvement
>            Reporter: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.3, 1.4
>
>         Attachments: SQLNestedException.patch
>
>
> SQLNestedException in its current state is a hangover from supporting JDK 1.3 when there was no "initCause()" method. This implementation can now be greatly simplified with DBCP now having a minimum of JDK 1.4
> Also SQLNestedException is deprecated and the following code has been used in a number of places
> {code}
>      throw (SQLException )new SQLException(message).initCause(e)
> {code}
> DBCP is inconsistent though - sometimes using the above and sometimes using SQLNestedException. IMO SQLNestedException  should be un-deprecated and used consistently everywhere - its now a simple implementation and I think the code is cleaner using it rather than the above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.