Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 9506 invoked from network); 8 Nov 2009 01:58:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Nov 2009 01:58:55 -0000 Received: (qmail 35559 invoked by uid 500); 8 Nov 2009 01:58:55 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 35452 invoked by uid 500); 8 Nov 2009 01:58:54 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 35442 invoked by uid 99); 8 Nov 2009 01:58:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Nov 2009 01:58:54 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Nov 2009 01:58:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5FD59234C045 for ; Sat, 7 Nov 2009 17:58:32 -0800 (PST) Message-ID: <284081870.1257645512378.JavaMail.jira@brutus> Date: Sun, 8 Nov 2009 01:58:32 +0000 (UTC) From: "Dan Fabulich (JIRA)" To: issues@commons.apache.org Subject: [jira] Created: (DBUTILS-64) FindBugs reportrs "bad practice" in QueryLoader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 FindBugs reportrs "bad practice" in QueryLoader ----------------------------------------------- Key: DBUTILS-64 URL: https://issues.apache.org/jira/browse/DBUTILS-64 Project: Commons DbUtils Issue Type: Bug Affects Versions: 1.2, 1.1, 1.3 Reporter: Dan Fabulich Priority: Minor Usage of GetResource in org.apache.commons.dbutils.QueryLoader.loadQueries(String) may be unsafe if class is extended Line 97 http://findbugs.sourceforge.net/bugDescriptions.html#UI_INHERITANCE_UNSAFE_GETRESOURCE UI: Usage of GetResource may be unsafe if class is extended (UI_INHERITANCE_UNSAFE_GETRESOURCE) Calling this.getClass().getResource(...) could give results other than expected if this class is extended by a class in another package. To fix this, I think we'd need to change QueryLoader to allow you to specify the class for relative path handling. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.