commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julien Aymé (JIRA) <>
Subject [jira] Updated: (DBUTILS-54) Generated key handling for updates
Date Tue, 03 Nov 2009 10:37:59 GMT


Julien Aymé updated DBUTILS-54:

    Attachment: QueryRunner.patch

Patch proposal.

It contains some new methods, named "insertAndGetKeys", copied from the update methods, with
an aditionnal parameter: the ResultSetHandler, which is used to transform the generated keys
into a java object.

The return type as been changed from int (number of rows updated) to the result of the ResultSetHandler.

The name has been changed from update to insert since only INSERT statement can generate keys

I had to add an additional prepareStatement method in order to maintain backward comptability,
as well as code simplicity.

Comments and reviews are greatly appreciated.

> Generated key handling for updates
> ----------------------------------
>                 Key: DBUTILS-54
>                 URL:
>             Project: Commons DbUtils
>          Issue Type: Improvement
>    Affects Versions: 1.2, Nightly Builds
>            Reporter: Michael V
>            Priority: Minor
>         Attachments: QueryRunner.patch
> It would be great (and fairly easy to do) to provide a way to get autogenerated keys
from QueryRunner.update. There was an email thread about this in 2004 but it seems it never
was actually implemented.
> The thought is to provide an ability to recover generated keys, for instance by providing
a result set handler, in which case prepared statement would be generated with RETURN_GENERATED_KEYS
and getGeneratedKeys() would be passed to the result handler.
> It seems that in 1.2 there is a way to get PreparedStatement and work with QueryRunner
more as a support to JDBC but IMO it would be cool to add this feature.
> example solution:
> {noformat} 
>     public int update(Connection conn, String sql, Object... params)
>         throws SQLException {
>           update(sql, null, params);
>     }
>     protected PreparedStatement prepareStatement(Connection conn, String sql, int autoGeneratedKeys)
>         throws SQLException {
>         return conn.prepareStatement(sql, autoGeneratedKeys);
>     }
>     public int update(Connection conn, String sql, ResultSetHandler<?> rsh, Object...
>         throws SQLException {
>         PreparedStatement stmt = null;
>         int rows = 0;
>         try {
>             stmt = this.prepareStatement(conn, sql, rsh==null?Statement.NO_GENERATED_KEY:Statement.RETURN_GENERATED_KEYS);
>             this.fillStatement(stmt, params);
>             rows = stmt.executeUpdate();
>             if(rsh!=null)
>                  rsh.handle(stmt.getGeneratedKeys());
>         } catch (SQLException e) {
>             this.rethrow(e, sql, params);
>         } finally {
>             close(stmt);
>         }
>         return rows;
>     }
> {noformat} 
> Thanks!

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message