commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralph Goers (JIRA)" <>
Subject [jira] Commented: (VFS-288) unable to browse hidden directories (regression fix overrode VFS-210:)
Date Fri, 06 Nov 2009 20:42:32 GMT


Ralph Goers commented on VFS-288:

I tried to apply this patch but when I ran FtpProviderTestCase it failed in ContentTests testChildren
at line 182. That test seems to be explicitly checking that an exception gets thrown on an
unknown file. The reason the change this issue references was made was because this unit test
was failing. I didn't write the unit test and with test driven development I believe that
that is the expected behavior. It would seem that the patch for VFS-210 was not tested against
the existing unit tests.

I am not sure which behavior is "right" or "wrong", but I am hesitant to apply this without
further discussion.

> unable to browse hidden directories (regression fix overrode VFS-210:) 
> -----------------------------------------------------------------------
>                 Key: VFS-288
>                 URL:
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>         Environment: java
>            Reporter: Mark O'Donohue
>         Attachments: patch.diff
> The regression fix: 
>       r742127 | rgoers | 2009-02-09 03:37:32 +1100 (Mon, 09 Feb 2009) | 1 line
>       Fix unit test - throw exception if child is not a directory
> Now means that FTP hidden directories cannot be listed, since the getType() has to return
a DIRECTORY value.  The overwrote the earlier change:
>       ------------------------------------------------------------------------
>       r659785 | imario | 2008-05-24 20:32:41 +1000 (Sat, 24 May 2008) | 1 line
>       VFS-210: First development iteration. Most important methods now work more like
a wrapper,    you should already see a major increase in performance with ftp and large directories
as long as no method (or your code) calls getFileType(). Hidden and special files should work
now too .. as long as you know the path, for sure.
> That allowed hidden directories to be listed. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message