Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 45147 invoked from network); 29 Oct 2009 22:10:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 29 Oct 2009 22:10:23 -0000 Received: (qmail 88450 invoked by uid 500); 29 Oct 2009 22:10:22 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 88338 invoked by uid 500); 29 Oct 2009 22:10:22 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 88324 invoked by uid 99); 29 Oct 2009 22:10:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Oct 2009 22:10:22 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Oct 2009 22:10:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 79369234C04C for ; Thu, 29 Oct 2009 15:09:59 -0700 (PDT) Message-ID: <985754492.1256854199495.JavaMail.jira@brutus> Date: Thu, 29 Oct 2009 22:09:59 +0000 (UTC) From: "Jake Mannix (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (MATH-313) Functions could be more object-oriented without losing any power. In-Reply-To: <2066637627.1256803739367.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771651#action_12771651 ] Jake Mannix commented on MATH-313: ---------------------------------- At least within Commons-math, nowhere do people have complex classes which implement UnivariateRealFunction, they have static inner classes (or anonymous inner classes) which do the work for them, and I was able to replace all such occurences with AbstractUnivariateRealFunction without much trouble. I've already got a patch which easily takes care of this throughout all of commons-math. Are you saying that people outside of commons-math, who are using it, have their solver classes implement a function interface as well? > Functions could be more object-oriented without losing any power. > ----------------------------------------------------------------- > > Key: MATH-313 > URL: https://issues.apache.org/jira/browse/MATH-313 > Project: Commons Math > Issue Type: New Feature > Affects Versions: 2.0 > Environment: all > Reporter: Jake Mannix > Fix For: 2.1 > > > UnivariateRealFunction, for example, is a map from R to R. The set of such functions has tons and tons of structure: in addition to being an algebra, equipped with +,-,*, and scaling by constants, it maps the same space into itself, so it is composable, both pre and post. > I'd propose we add: > {code} > UnivariateRealFunction plus(UnivariateRealFunction other); > UnivariateRealFunction minus(UnivariateRealFunction other); > UnivariateRealFunction times(UnivariateRealFunction other); > UnivariateRealFunction times(double scale); > UnivariateRealFunction preCompose(UnivariateRealFunction other); > UnivariateRealFunction postCompose(UnivariateRealFunction other); > {code} > to the interface, and then implement them in an AbstractUnivariateRealFunction base class. No implementer would need to notice, other than switching to extend this class rather than implement UnivariateRealFunction. > Many people don't need or use this, but... it makes for some powerfully easy code: > {code}UnivariateRealFunction gaussian = Exp.preCompose(Negate.preCompose(Pow2));{code} > which is even nicer when done anonymously passing into a map/collect method (a la MATH-312). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.