Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <857906104.1256013119404.JavaMail.jira@brutus>
Date: Tue, 20 Oct 2009 04:31:59 +0000 (UTC)
From: "Henri Yandell (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Closed: (LANG-293) StringEscapeUtils.unescape* can be faster
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/LANG-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-293.
------------------------------

    Resolution: Won't Fix

Apologies - but after the rewrite the patch isn't relevant anymore. I had a stab at recreating the spirit of the patch by short circuiting early, but it didn't improve speed in my tests. I'm sure there are speed improvements, but probably needs to take a fresh start on the code.

Again - apologies that the code was rewritten before your patch could be applied.

> StringEscapeUtils.unescape* can be faster
> -----------------------------------------
>
>                 Key: LANG-293
>                 URL: https://issues.apache.org/jira/browse/LANG-293
>             Project: Commons Lang
>          Issue Type: Improvement
>    Affects Versions: Nightly Builds
>            Reporter: Stepan Koltsov
>             Fix For: 3.0
>
>         Attachments: commons-lang-unescape-performace2-stepancheg-2006-10-31.diff, EntitiesPerformance2TestSecret.java
>
>
> Typical string that need to be unescaped contains almost no XML entities, so copying input string to output buffer char by char is slow.
> I've refactored Entities.unescape() so it works faster. Going to submitting patch and tests.
> Patch contains both hacked and original versions of unescape, to run tests.
> Test shows that performance remains same on short strings, and much better or large strings with rare entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.