Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 80708 invoked from network); 21 Oct 2009 13:50:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Oct 2009 13:50:23 -0000 Received: (qmail 38842 invoked by uid 500); 21 Oct 2009 13:50:22 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 38743 invoked by uid 500); 21 Oct 2009 13:50:22 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 38733 invoked by uid 99); 21 Oct 2009 13:50:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Oct 2009 13:50:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Oct 2009 13:50:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 58502234C045 for ; Wed, 21 Oct 2009 06:49:59 -0700 (PDT) Message-ID: <538229113.1256132999357.JavaMail.jira@brutus> Date: Wed, 21 Oct 2009 13:49:59 +0000 (UTC) From: "James Carman (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (DIGESTER-135) Digester rules defined through Java5 Annotatations In-Reply-To: <87202288.1254984811286.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DIGESTER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768240#action_12768240 ] James Carman commented on DIGESTER-135: --------------------------------------- I'm not so sure about this approach. One thing that jumped out at me was the @SetNext annotation. When you're building up your digester by hand, you have some context of where you are when you set up your rules. With that @SetNext, how do you know where you are? How do you know your context? It would be easy for the classes to get out of synch. I think we'd be better off creating a rules builder API that reads more like English. > Digester rules defined through Java5 Annotatations > -------------------------------------------------- > > Key: DIGESTER-135 > URL: https://issues.apache.org/jira/browse/DIGESTER-135 > Project: Commons Digester > Issue Type: Improvement > Affects Versions: 2.1 > Reporter: Simone Tripodi > Priority: Minor > Fix For: 2.1 > > Attachments: DigesterAnnotations.patch > > > Taking inspiration by Google-Guice, JAXB and JPA's annotations, the existing package can be extended adding some facilities to configure the commons-digester using the Java language metadata annotations. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.