Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 38242 invoked from network); 27 Oct 2009 23:06:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Oct 2009 23:06:09 -0000 Received: (qmail 41198 invoked by uid 500); 27 Oct 2009 21:19:29 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 41098 invoked by uid 500); 27 Oct 2009 21:19:29 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 41088 invoked by uid 99); 27 Oct 2009 21:19:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 21:19:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 21:19:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 85E84234C04C for ; Tue, 27 Oct 2009 14:18:59 -0700 (PDT) Message-ID: <1523103101.1256678339547.JavaMail.jira@brutus> Date: Tue, 27 Oct 2009 21:18:59 +0000 (UTC) From: "Nipun Jawalkar (JIRA)" To: issues@commons.apache.org Subject: [jira] Issue Comment Edited: (MATH-311) Replaced the BinomialDistribution existing PDF with Catherine Loader's algorithm (as per wishlist on the wiki page) In-Reply-To: <1309086521.1256678219440.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MATH-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770647#action_12770647 ] Nipun Jawalkar edited comment on MATH-311 at 10/27/09 9:18 PM: --------------------------------------------------------------- Patch to update both BinomialDistributionImpl.java as well as the matching unit test, BinomialDistributionTest.java was (Author: njawalkar): Path to update both BinomialDistributionImpl.java as well as the matching unit test, BinomialDistributionTest.java > Replaced the BinomialDistribution existing PDF with Catherine Loader's algorithm (as per wishlist on the wiki page) > ------------------------------------------------------------------------------------------------------------------- > > Key: MATH-311 > URL: https://issues.apache.org/jira/browse/MATH-311 > Project: Commons Math > Issue Type: Improvement > Reporter: Nipun Jawalkar > Priority: Minor > Attachments: BinomialDistributionPatch.txt > > > The existing PDF for Binomial distributions cannot handle n>1029. This implementation of Catherine Loader's algorithm can handle n upto and larger than 1000000. The Commons-Math wiki page has a wishlist entry asking for this, with a link to the paper describing the new algorithm: http://projects.scipy.org/scipy/raw-attachment/ticket/620/loader2000Fast.pdf > I've updated the probability() function in BInomialDistributionImpl.java, as well as the unit test for this method. The updated unit test has higher precision expected values, which were calculated with Mathematica 6. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.