commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Closed: (LANG-540) Make NumericEntityEscaper immutable
Date Fri, 23 Oct 2009 06:47:59 GMT

     [ https://issues.apache.org/jira/browse/LANG-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell closed LANG-540.
------------------------------

    Resolution: Fixed

Two patches and line to NumericEntityEscaper added:

------------------------------------------------------------------------
r828944 | bayard | 2009-10-22 23:46:02 -0700 (Thu, 22 Oct 2009) | 1 line
Changed paths:
   M /commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/UnicodeEscaper.java

Making the private fields final via Sebb's patch from LANG-540
------------------------------------------------------------------------
r828943 | bayard | 2009-10-22 23:44:45 -0700 (Thu, 22 Oct 2009) | 1 line
Changed paths:
   M /commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/LookupTranslator.java

Making private fields final per Sebb's patch to LANG-540
------------------------------------------------------------------------
r828942 | bayard | 2009-10-22 23:43:26 -0700 (Thu, 22 Oct 2009) | 1 line
Changed paths:
   M /commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/NumericEntityEscaper.java

Adding back the empty constructor per Sebb's comment on LANG-540

> Make NumericEntityEscaper immutable
> -----------------------------------
>
>                 Key: LANG-540
>                 URL: https://issues.apache.org/jira/browse/LANG-540
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 3.0
>
>         Attachments: LookupTranslator.patch, NumericEntityEscaper.patch, UnicodeEscaper.patch
>
>
> NumericEntityEscaper is currently mutable and not thread-safe.
> It can easily be made immutable (and thus thread-safe) by using a private constructor
to set the instance fields.
> See patch to follow.
> A similar approach can be used for some of the other classes in the translate package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message