commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Closed: (LANG-422) StrBuilder appendSeparator with defaultIfEmpty
Date Tue, 20 Oct 2009 06:12:59 GMT

     [ https://issues.apache.org/jira/browse/LANG-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell closed LANG-422.
------------------------------

    Resolution: Fixed

Patch applied in:

r826969 | bayard | 2009-10-19 23:10:10 -0700 (Mon, 19 Oct 2009) | 1 line
Changed paths:
   M /commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
   M /commons/proper/lang/trunk/src/test/org/apache/commons/lang/text/StrBuilderAppendInsertTest.java

Applying Robert Scholte's patch from LANG-422, adding a appendSeparator with an alternative
default separator if the StrBuilder is currently empty

> StrBuilder appendSeparator with defaultIfEmpty
> ----------------------------------------------
>
>                 Key: LANG-422
>                 URL: https://issues.apache.org/jira/browse/LANG-422
>             Project: Commons Lang
>          Issue Type: Improvement
>    Affects Versions: 2.4
>            Reporter: Robert Scholte
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LANG-422-RS.patch
>
>
> If would like to suggest the following method for the StrBuilder class:
> *appendSeparator(String separator, String defaultIfEmpty)*
> it's usage is very handy for building queries (a much more I guess)
> {code}
> StrBuilder whereClause = new StrBuilder();
> if(searchCommand.priority != null) {
>   whereClause.appendSeparator(" and", " where");
>   whereClause.append(" priority = ?")
> }
> if(searchCommand.component != null) {
>   whereClause.appendSeparator(" and", " where");
>   whereClause.append(" component = ?")
> }
> // if(!whereClause.isEmpty()) {
> // selectClause.append(" where")
> // selectClause.append(whereClause)
> //}
> selectClause.append(whereClause)
> {code}
> this can be done for every queryClause (eliminating all isEmpty-checks), but there are
usefull usecases

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message