commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (LANG-540) Make NumericEntityEscaper immutable
Date Fri, 23 Oct 2009 00:43:59 GMT

     [ https://issues.apache.org/jira/browse/LANG-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb reopened LANG-540:
-----------------------


I've just realised that my patch removed the default public constructor.
This can be remedied by adding:

    public NumericEntityEscaper(){
        this(0, Integer.MAX_VALUE, true);
    }


Also, a similar patch can be applied to UnicodeEscaper, patch to follow.


> Make NumericEntityEscaper immutable
> -----------------------------------
>
>                 Key: LANG-540
>                 URL: https://issues.apache.org/jira/browse/LANG-540
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 3.0
>
>         Attachments: NumericEntityEscaper.patch
>
>
> NumericEntityEscaper is currently mutable and not thread-safe.
> It can easily be made immutable (and thus thread-safe) by using a private constructor
to set the instance fields.
> See patch to follow.
> A similar approach can be used for some of the other classes in the translate package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message